Drive invalid in AXI VCs #802
Conversation
| drive_w_invalid; | ||
|
|
||
| loop | ||
| wait until rising_edge(aclk) and not is_empty(message_queue); |
There was a problem hiding this comment.
This is mainly an indentation change due to the loop statement. Github renders it really bad.
|
Note that this changes the default behavior of the three VCs, so in some sense it is a breaking change. This could be changed by setting the default value |
|
Looks good to me! Added a small comment on an unused constant. |
|
@LarsAsplund Sorry to ping you like this, but would it be possible to merge this? It has been reviewed by Ludvig. |
|
LGTM too. |
|
@LukasVik Sorry for the delay. It's in the pipe but unfortunately I haven't had time to work on that pipe. Been more of that lately so I will deal with shortly... I hope |
|
@LarsAsplund No problem at all, I know how it is. @std-max Well with the default value With that said, I agree with you in the sense that I personally will always leave the |
When the 'valid' signal is low for an AXI (-Lite) channel, the signals of the channel should be driven with 'X'. They should not keep their value from the last time the channel was valid. This can hide errors in the DUT if the DUT samples values in the wrong clock cycle. This change is largely inspired by the AXI-Stream VCs.
|
I rebased the source branch upon upstream master in order to solve a merge conflict. No functional changes apart from that. Is ready for review/merge. |
When the 'valid' signal is low for an AXI (-Lite) channel, the signals of the channel should be driven with 'X'.
They should not keep their value from the last time the channel was valid.
This can hide errors in the DUT if the DUT samples values in the wrong clock cycle.
This change is largely inspired by the AXI-Stream VCs.